feat: Search facets #103
feat: Search facets #103
Conversation
alexgarel
force-pushed
the
search-facets
branch
from
138a517
to
c85b23f
Compare
|
Cool! It would be nice to have a "Apply new filters" button that appears below the facets, as it's not intuitive that we need to click on the search button again to apply them. |
| - labels_tags | ||
| - ecoscore_grade | ||
| - nova_groups | ||
| - ecoscore_grade |
There was a problem hiding this comment.
ecoscore_grade is already there, nutriscore maybe?
There was a problem hiding this comment.
I have to remove that, this is not useful any more… now it's the interface that requests facets (more logical).
Co-authored-by: Pierre Slamich <[email protected]>
Yes, in another PR ;-) |
frontend/src/search-facets.ts
Outdated
| } else { | ||
| return html``; // FIXME: is this ok ? | ||
| } |
There was a problem hiding this comment.
What this comment highlight ?
If the return html'' render nothing ?
There was a problem hiding this comment.
Yes, I was not sure when I code, now it seems ok, I will remove the FIXME :-)
It's possible to updates results when you check any filter |
I personally don't like it much because it makes it hard to select two filters at once… |
Limitations:
facets-demo.mp4